Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] 100 continue triggered by content request #5714

Merged
merged 4 commits into from
Jan 19, 2023
Merged

[3.x] 100 continue triggered by content request #5714

merged 4 commits into from
Jan 19, 2023

Conversation

danielkec
Copy link
Contributor

Fixes #4912

100 Continue is triggered by requesting content data.

req.content()
    .as(String.class)
     // Requesting data from content triggers 100 continue
    .forSingle(s -> res.send("Got "+s.getBytes().length+" bytes of data"));

@danielkec danielkec self-assigned this Dec 16, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 16, 2022
@danielkec danielkec marked this pull request as draft December 16, 2022 21:52
@danielkec danielkec marked this pull request as ready for review January 5, 2023 13:12
@danielkec
00 continue
fe4c91e 
 * Expectation failed HttpObjectDecoder reset

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Review issues
ddd792b
@danielkec
Backward compatible flag
1e43b50
@danielkec danielkec mentioned this pull request Jan 19, 2023
Closed
3 tasks
@danielkec danielkec added the 3.x Issues for 3.x version branch label Jan 19, 2023
@danielkec danielkec changed the title 100 continue triggered by content request [3.x] 100 continue triggered by content request Jan 19, 2023
@danielkec danielkec merged commit 7fd887c into helidon-io:helidon-3.x Jan 19, 2023
danielkec added a commit to danielkec/helidon that referenced this pull request Jan 31, 2023
@danielkec
100 continue triggered by content request - reactive (helidon-io#5714)
cab9e0c
danielkec added a commit to danielkec/helidon that referenced this pull request Jan 31, 2023
@danielkec
100 continue triggered by content request - nima (helidon-io#5714)
5989c97
danielkec added a commit that referenced this pull request Feb 1, 2023
@danielkec
100 continue triggered by content request - reactive (#5714)
32a5381
danielkec added a commit that referenced this pull request Feb 1, 2023
@danielkec
100 continue triggered by content request - nima (#5714)
bbdb93b
@danielkec danielkec added this to the 3.1.1 milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@danielkec danielkec

Labels
3.x Issues for 3.x version branch OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

Allow Helidon server to properly implement Expect: 100-continue protocol
2 participants
@danielkec @tomas-langer